[all-commits] [llvm/llvm-project] 3e70a9: [lldb/Plugin] Use LLDB_PLUGIN_DECLARE to forward d...

[Jonas Devlieghere via All-commits]

  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: 3e70a9196387437abb794b294d47fde37684337d
      https://github.com/llvm/llvm-project/commit/3e70a9196387437abb794b294d47fde37684337d
  Author: Jonas Devlieghere <jonas at devlieghere.com>
  Date:   2020-02-07 (Fri, 07 Feb 2020)

  Changed paths:
    M lldb/include/lldb/Core/PluginManager.h
    M lldb/source/API/SystemInitializerFull.cpp
    M lldb/tools/lldb-test/SystemInitializerTest.cpp

  Log Message:
  -----------
  [lldb/Plugin] Use LLDB_PLUGIN_DECLARE to forward declare plugin initializers

Apparently Linux and Windows have the exact opposite behavior when it
comes to inline declarations of external functions. On Linux they're
considered to be part of the lldb_private namespace, while on Windows
they're considered to be part of the top level namespace. Somehow on
macOS, it doesn't really matter and both are fine...

At this point I don't know what to do, so I'm just adding the
LLDB_PLUGIN_DECLARE macros again as originally proposed in D74245.