[all-commits] [llvm/llvm-project] d53c8c: [lldb/tests] Correctly configure the lldb dotest a...

Stella Stamenova via All-commits all-commits at lists.llvm.org
Thu Feb 6 10:27:27 PST 2020


  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: d53c8c6af5223e4098b395175f0bfaf75721fb79
      https://github.com/llvm/llvm-project/commit/d53c8c6af5223e4098b395175f0bfaf75721fb79
  Author: Stella Stamenova <stilis at microsoft.com>
  Date:   2020-02-06 (Thu, 06 Feb 2020)

  Changed paths:
    M lldb/test/API/lit.site.cfg.py.in
    M lldb/utils/lldb-dotest/CMakeLists.txt
    M lldb/utils/lldb-dotest/lldb-dotest.in

  Log Message:
  -----------
  [lldb/tests] Correctly configure the lldb dotest arguments

Summary:
When the generator used for CMake is a multi-configuration generator (such as VS), the arguments passed to dotest are not currently configured correctly. There are a couple of issues:
1) The per-configuration files are all generated for the same configuration since the for loop overwrites the properties
2) Not all of the parameters are configured in the lit cfg, so they end up with %(build_mode)s as configuration and they point to non-existent paths

Reviewers: JDevlieghere

Reviewed By: JDevlieghere

Subscribers: mgorny, lldb-commits, asmith

Tags: #lldb

Differential Revision: https://reviews.llvm.org/D74093




More information about the All-commits mailing list