[all-commits] [llvm/llvm-project] d0104a: Make llvm::crc32() work also for input sizes large...

Hans via All-commits all-commits at lists.llvm.org
Thu Feb 6 00:06:37 PST 2020


  Branch: refs/heads/release/10.x
  Home:   https://github.com/llvm/llvm-project
  Commit: d0104a596199a41963dbba70338d9ff3c36b185a
      https://github.com/llvm/llvm-project/commit/d0104a596199a41963dbba70338d9ff3c36b185a
  Author: Hans Wennborg <hans at chromium.org>
  Date:   2020-02-06 (Thu, 06 Feb 2020)

  Changed paths:
    M llvm/lib/Support/CRC.cpp
    M llvm/unittests/Support/CRCTest.cpp

  Log Message:
  -----------
  Make llvm::crc32() work also for input sizes larger than 32 bits.

The problem was noticed by the Chrome OS toolchain folks
(crbug.com/1048445) because llvm-objcopy --add-gnu-debuglink would
insert the wrong checksum when processing a binary larger than 4 GB.
That use case regressed in 1e1e3ba2526 when we started using
llvm::crc32() in more places.

Differential revision: https://reviews.llvm.org/D74039

(cherry picked from commit 6c4a8bc0a9f6a466d90d542bef66d69550c1b041)




More information about the All-commits mailing list