[all-commits] [llvm/llvm-project] 69cc9f: AMDGPU/GlobalISel: Legalize llvm.amdgcn.s.buffer.load

[Matt Arsenault via All-commits]

  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: 69cc9f3046cedcebabe2293de0acba408d181eb4
      https://github.com/llvm/llvm-project/commit/69cc9f3046cedcebabe2293de0acba408d181eb4
  Author: Matt Arsenault <Matthew.Arsenault at amd.com>
  Date:   2020-02-05 (Wed, 05 Feb 2020)

  Changed paths:
    M llvm/lib/Target/AMDGPU/AMDGPULegalizerInfo.cpp
    M llvm/lib/Target/AMDGPU/AMDGPULegalizerInfo.h
    A llvm/test/CodeGen/AMDGPU/GlobalISel/legalize-llvm.amdgcn.s.buffer.load.mir

  Log Message:
  -----------
  AMDGPU/GlobalISel: Legalize llvm.amdgcn.s.buffer.load

The 96-bit results need to be widened.

I find the interaction between LegalizerHelper and MIRBuilder somewhat
awkward. The custom legalization is called by the LegalizerHelper, but
then does not have access to the helper. You have to construct a new
helper, which then does not own the MachineIRBuilder, but does modify
it. Maybe custom legalization should be passed the helper?