[all-commits] [llvm/llvm-project] 8d8bd0: [lldb] Make TestDataFormatterObjCCF.py pass outsid...
Raphael Isemann via All-commits
all-commits at lists.llvm.org
Wed Feb 5 04:24:28 PST 2020
Branch: refs/heads/master
Home: https://github.com/llvm/llvm-project
Commit: 8d8bd0d6548ed9d2482de341c1b0e53449e5c564
https://github.com/llvm/llvm-project/commit/8d8bd0d6548ed9d2482de341c1b0e53449e5c564
Author: Raphael Isemann <teemperor at gmail.com>
Date: 2020-02-05 (Wed, 05 Feb 2020)
Changed paths:
M lldb/packages/Python/lldbsuite/test/functionalities/data-formatter/data-formatter-objc/TestDataFormatterObjCCF.py
M lldb/packages/Python/lldbsuite/test/functionalities/data-formatter/data-formatter-objc/main.m
Log Message:
-----------
[lldb] Make TestDataFormatterObjCCF.py pass outside California
Summary:
This test creates its dates with `NSDate dateWithNaturalLanguageString` which is deprecated and uses the current time zone of the machine to
interpret the input string. This causes that the created NSDate has a different value depending on the locale of the machine
and we hardcoded the value for California's time zone (PST) but the data formatter gives out the GMT value as a string.
This just replaces the use with the timezone-independent dateWithTimeIntervalSince1970 (which we also use in the rest of the test)
to make this pass independently of the time zone of the machine running the test.
Reviewers: mib
Reviewed By: mib
Subscribers: lldb-commits, JDevlieghere
Tags: #lldb
Differential Revision: https://reviews.llvm.org/D74038
More information about the All-commits
mailing list