[all-commits] [llvm/llvm-project] 843a0f: Enhance debugserver's err reporting on attach fails

[Jason Molenda via All-commits]

  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: 843a0f97717a006fd21cd89fd229b064506e5d05
      https://github.com/llvm/llvm-project/commit/843a0f97717a006fd21cd89fd229b064506e5d05
  Author: Jason Molenda <jmolenda at apple.com>
  Date:   2020-02-04 (Tue, 04 Feb 2020)

  Changed paths:
    M lldb/tools/debugserver/source/DNB.cpp
    M lldb/tools/debugserver/source/DNB.h
    M lldb/tools/debugserver/source/RNBRemote.cpp
    M lldb/tools/debugserver/source/RNBServices.cpp

  Log Message:
  -----------
  Enhance debugserver's err reporting on attach fails

Explicitly check for a request to attach to a pid that doesn't
exist, to attach to a pid that is already being debugged, unify the
SIP process check, and an attempt at checking if developer mode is
enabled on the system (which isn't working in debugserver, for some
reason; I can't get the authorization record which should be an
unprivileged operation and works in a standalone program I wrote).

I'll debug the developer mode check later, but I wanted to land it
along with everything else; right now it will claim that developer
mode is always enabled so it's harmless to include as-is.