[all-commits] [llvm/llvm-project] 9260d0: AMDGPU: Correct memory size for image intrinsics

Matt Arsenault via All-commits all-commits at lists.llvm.org
Tue Feb 4 19:29:29 PST 2020


  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: 9260d01faa664d557feeeec8df2f5c7561bb4a95
      https://github.com/llvm/llvm-project/commit/9260d01faa664d557feeeec8df2f5c7561bb4a95
  Author: Matt Arsenault <Matthew.Arsenault at amd.com>
  Date:   2020-02-04 (Tue, 04 Feb 2020)

  Changed paths:
    M llvm/lib/Target/AMDGPU/SIISelLowering.cpp

  Log Message:
  -----------
  AMDGPU: Correct memory size for image intrinsics

This was incorrectly rounding up to the next power of 2. v4f32 was
rounding up to v8f32, which was just wrong. There are also v3i16/v3f16
available in MVT, so we don't even need to round the f16 cases
anymore. Additionally, this field is really an EVT so we don't even
need to consider this.

Also switch some asserts to return invalid. We should have an IR
verifier for these intrinsic return types, but for now it's better to
not assert on IR that passes the verifier.

This should also probably be fixed to consider that dmask is really
eliminating some of the loaded components.




More information about the All-commits mailing list