[all-commits] [llvm/llvm-project] b453ca: [lldb/Reproducers] Change the way we instrument vo...

[Jonas Devlieghere via All-commits]

  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: b453caf1112f0e89eddcd03aa667368fab6d13d6
      https://github.com/llvm/llvm-project/commit/b453caf1112f0e89eddcd03aa667368fab6d13d6
  Author: Jonas Devlieghere <jonas at devlieghere.com>
  Date:   2020-02-04 (Tue, 04 Feb 2020)

  Changed paths:
    M lldb/include/lldb/Utility/ReproducerInstrumentation.h
    M lldb/source/API/SBTarget.cpp
    M lldb/source/Utility/ReproducerInstrumentation.cpp
    M lldb/tools/lldb-instr/Instrument.cpp

  Log Message:
  -----------
  [lldb/Reproducers] Change the way we instrument void* arguments

The reproducer instrumentation cannot automatically serialize and
deserialize void* arguments. Currently we deal with this by explicitly
preventing these methods from being instrumented. This has the undesired
side effect of breaking replay when that method returns a value later
used by another SB API call.

The solution is to change our approach and instrument these methods.
Instead of using the DUMMY macro, we just make (de)serialization of the
void pointer a NOOP and always return a nullptr.