[all-commits] [llvm/llvm-project] 50d2d3: Fix BroadcasterManager::RemoveListener to really r...

Reid Kleckner via All-commits all-commits at lists.llvm.org
Tue Feb 4 17:19:48 PST 2020

  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: 50d2d33b8ef530fbee369cbf8e7ea4479597742d
  Author: Reid Kleckner <rnk at google.com>
  Date:   2020-02-04 (Tue, 04 Feb 2020)

  Changed paths:
    M lldb/source/Utility/Broadcaster.cpp

  Log Message:
  Fix BroadcasterManager::RemoveListener to really remove the listener

This appears to be a real bug caught by -Wunused-value. std::find_if
doesn't modify the underlying collection, it just returns an iterator
pointing to the matching element.

Reviewed By: JDevlieghere

Differential Revision: https://reviews.llvm.org/D74010

More information about the All-commits mailing list