[all-commits] [llvm/llvm-project] 7ac944: [lldb/Reproducers] Change record logging to mirror...

[Jonas Devlieghere via All-commits]

  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: 7ac9443002949a01c992691760588eaaf88e4f41
      https://github.com/llvm/llvm-project/commit/7ac9443002949a01c992691760588eaaf88e4f41
  Author: Jonas Devlieghere <jonas at devlieghere.com>
  Date:   2020-02-04 (Tue, 04 Feb 2020)

  Changed paths:
    M lldb/include/lldb/Utility/ReproducerInstrumentation.h

  Log Message:
  -----------
  [lldb/Reproducers] Change record logging to mirror replay logging

Pretty printing the return value, although a good idea in theory, turned
out to be more confusing than anything else because they require
printing the log statement after the arguments and resulting value have
been serialized.

This changes the logging to behave more like how deserialization is
traced, although a bit more verbose because some of the serializers are
are calling each other.


  Commit: ddf814688bd4b2268e8648999b23352e7c6521cb
      https://github.com/llvm/llvm-project/commit/ddf814688bd4b2268e8648999b23352e7c6521cb
  Author: Jonas Devlieghere <jonas at devlieghere.com>
  Date:   2020-02-04 (Tue, 04 Feb 2020)

  Changed paths:
    M lldb/include/lldb/Utility/ReproducerInstrumentation.h

  Log Message:
  -----------
  [lldb/Reproducers] Add underscore to varaibles in LLDB_RECORD macros

Rename all variables used in the LLDB_RECORD macros to start with an
underscore to avoid conflicts with the arguments being recorded.


Compare: https://github.com/llvm/llvm-project/compare/016f42e3dcd8...ddf814688bd4