[all-commits] [llvm/llvm-project] 7c9ebd: [lldb] Remove clang classes from lldb-forward.h

Alex via All-commits all-commits at lists.llvm.org
Tue Feb 4 14:24:12 PST 2020


  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: 7c9ebdd3d6ae405dc6702e544453a51862daf948
      https://github.com/llvm/llvm-project/commit/7c9ebdd3d6ae405dc6702e544453a51862daf948
  Author: Alex Langford <apl at fb.com>
  Date:   2020-02-04 (Tue, 04 Feb 2020)

  Changed paths:
    M lldb/include/lldb/Target/Target.h
    M lldb/include/lldb/lldb-forward.h
    M lldb/source/Plugins/ExpressionParser/Clang/ClangASTImporter.h
    M lldb/source/Plugins/ExpressionParser/Clang/ClangASTSource.cpp
    M lldb/source/Plugins/ExpressionParser/Clang/ClangASTSource.h
    M lldb/source/Plugins/ExpressionParser/Clang/ClangExpressionDeclMap.cpp
    M lldb/source/Plugins/ExpressionParser/Clang/ClangExpressionDeclMap.h
    M lldb/source/Plugins/ExpressionParser/Clang/ClangExpressionHelper.h
    M lldb/source/Plugins/ExpressionParser/Clang/ClangExpressionParser.h
    M lldb/source/Plugins/ExpressionParser/Clang/ClangPersistentVariables.cpp
    M lldb/source/Plugins/ExpressionParser/Clang/ClangPersistentVariables.h
    M lldb/source/Plugins/ExpressionParser/Clang/ClangUserExpression.cpp
    M lldb/source/Plugins/ExpressionParser/Clang/ClangUtilityFunction.cpp
    M lldb/source/Plugins/Language/CPlusPlus/BlockPointer.cpp
    M lldb/source/Plugins/LanguageRuntime/ObjC/ObjCLanguageRuntime.h
    M lldb/source/Plugins/TypeSystem/Clang/TypeSystemClang.h
    M lldb/unittests/Expression/ClangExpressionDeclMapTest.cpp

  Log Message:
  -----------
  [lldb] Remove clang classes from lldb-forward.h

Summary:
lldb-forward.h is convenient in many ways, but having clang-based
class forward declarations in there makes it easy to proliferate uses of clang
outside of plugins. Removing them makes you much more conscious of when
you're using something from clang and marks where we're using things
from clang in non-plugins.

Differential Revision: https://reviews.llvm.org/D73935




More information about the All-commits mailing list