[all-commits] [llvm/llvm-project] 2757f9: [lldb/Reproducers] Instrument SBFile

[Jonas Devlieghere via All-commits]

  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: 2757f93a5a76c59dddd39dc5c1f7c23ee5d21ff6
      https://github.com/llvm/llvm-project/commit/2757f93a5a76c59dddd39dc5c1f7c23ee5d21ff6
  Author: Jonas Devlieghere <jonas at devlieghere.com>
  Date:   2020-02-04 (Tue, 04 Feb 2020)

  Changed paths:
    M lldb/include/lldb/API/SBFile.h
    M lldb/source/API/SBFile.cpp

  Log Message:
  -----------
  [lldb/Reproducers] Instrument SBFile

Currently SBFile isn't really instrumented, which was causing trouble
when capturing and replaying the Python test suite. The class is
particularly tricky because one of its constructors takes a FileSP which
isn't instrumented. Until we have proper shadowing in place, we'll
simply always record a nullptr.

Differential revision: https://reviews.llvm.org/D73992


  Commit: f8c0fcd23dafbed38d0b6c1086b91f6474ad3f4c
      https://github.com/llvm/llvm-project/commit/f8c0fcd23dafbed38d0b6c1086b91f6474ad3f4c
  Author: Jonas Devlieghere <jonas at devlieghere.com>
  Date:   2020-02-04 (Tue, 04 Feb 2020)

  Changed paths:
    M lldb/include/lldb/Utility/ReproducerInstrumentation.h

  Log Message:
  -----------
  [lldb/Reproducers] Treat SB classes pass by value as const references

Unless trivially copyable, SB classes that are passed by value should be
treated as const references by the reproducer infrastructure and their
address should be serialized. This is already the case on the
serialization side, but not on the deserialization side. This fixes that
by removing the NotImplementedTag.


Compare: https://github.com/llvm/llvm-project/compare/83d0db59d6ff...f8c0fcd23daf