[all-commits] [llvm/llvm-project] de8451: GlobalISel: Fold SmallVector resizes into construc...

Matt Arsenault via All-commits all-commits at lists.llvm.org
Tue Feb 4 10:28:27 PST 2020


  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: de8451fe4d373b8fd1f8e4bec32e970268c7ac49
      https://github.com/llvm/llvm-project/commit/de8451fe4d373b8fd1f8e4bec32e970268c7ac49
  Author: Matt Arsenault <Matthew.Arsenault at amd.com>
  Date:   2020-02-04 (Tue, 04 Feb 2020)

  Changed paths:
    M llvm/lib/CodeGen/GlobalISel/LegalizerHelper.cpp

  Log Message:
  -----------
  GlobalISel: Fold SmallVector resizes into constructors


  Commit: 75fcdfa1fcf647d89f2e82fcfc7e8f2f310aa7d0
      https://github.com/llvm/llvm-project/commit/75fcdfa1fcf647d89f2e82fcfc7e8f2f310aa7d0
  Author: Matt Arsenault <Matthew.Arsenault at amd.com>
  Date:   2020-02-04 (Tue, 04 Feb 2020)

  Changed paths:
    M llvm/lib/Target/AMDGPU/AMDGPUISelDAGToDAG.cpp
    M llvm/lib/Target/AMDGPU/SMInstructions.td

  Log Message:
  -----------
  AMDGPU: Cleanup SMRD buffer selection

The usage of the Imm out argument from SelectSMRDOffset is pretty
confusing. Stop trying to reject CI immediates in the case where the
offset field can be used. It's not an illegal way to encode the
immediate, so just prefer the better encoding pattern with
AddedComplexity.

We probably don't even really need the different opcodes for the
different offset types anymore, but that will be more work to cleanup.

The SMRD non-buffer load patterns could also use a cleanup to be done
separately.


Compare: https://github.com/llvm/llvm-project/compare/f25a2a3de5b5...75fcdfa1fcf6


More information about the All-commits mailing list