[all-commits] [llvm/llvm-project] 262903: [clangd] Don't assert when completing a lambda var...
Sam McCall via All-commits
all-commits at lists.llvm.org
Tue Feb 4 08:28:44 PST 2020
Branch: refs/heads/master
Home: https://github.com/llvm/llvm-project
Commit: 2629035a009095f62f48413e175437261165ecd7
https://github.com/llvm/llvm-project/commit/2629035a009095f62f48413e175437261165ecd7
Author: Sam McCall <sam.mccall at gmail.com>
Date: 2020-02-04 (Tue, 04 Feb 2020)
Changed paths:
M clang-tools-extra/clangd/AST.cpp
M clang-tools-extra/clangd/AST.h
M clang-tools-extra/clangd/CodeComplete.cpp
M clang-tools-extra/clangd/Quality.cpp
M clang-tools-extra/clangd/unittests/CodeCompleteTests.cpp
Log Message:
-----------
[clangd] Don't assert when completing a lambda variable inside the lambda.
Summary:
This is a fairly ugly hack - we back off several features for any variable
whose type isn't deduced, to avoid computing/caching linkage.
Better suggestions welcome.
Fixes https://github.com/clangd/clangd/issues/274
Reviewers: kadircet, kbobyrev
Subscribers: ilya-biryukov, MaskRay, jkorous, arphaman, usaxena95, cfe-commits
Tags: #clang
Differential Revision: https://reviews.llvm.org/D73960
More information about the All-commits
mailing list