[all-commits] [llvm/llvm-project] 4581d9: [X86] Remove some uncovered and possibly broken co...

topperc via All-commits all-commits at lists.llvm.org
Mon Feb 3 22:59:52 PST 2020


  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: 4581d97416129cb2346de5041efc98891b13459d
      https://github.com/llvm/llvm-project/commit/4581d97416129cb2346de5041efc98891b13459d
  Author: Craig Topper <craig.topper at gmail.com>
  Date:   2020-02-03 (Mon, 03 Feb 2020)

  Changed paths:
    M llvm/lib/Target/X86/X86ISelLowering.cpp

  Log Message:
  -----------
  [X86] Remove some uncovered and possibly broken code from combineZext.

This code matches (zext (trunc (setcc_carry))) -> (and (setcc_carry), 1)
but the code never checks what type we're truncating too. An and
mask of 1 would only make sense if the trunc was to MVT::i1, but
we didn't check for that.

I believe this code is a leftover from when i1 was a legal type.




More information about the All-commits mailing list