[all-commits] [llvm/llvm-project] e211a7: Re-land "[lldb/Test] Make substrs argument to self...

[Jonas Devlieghere via All-commits]

  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: e211a7d2aafeeb9536f3aa9492601099655b833c
      https://github.com/llvm/llvm-project/commit/e211a7d2aafeeb9536f3aa9492601099655b833c
  Author: Jonas Devlieghere <jonas at devlieghere.com>
  Date:   2020-02-03 (Mon, 03 Feb 2020)

  Changed paths:
    M lldb/packages/Python/lldbsuite/test/commands/target/basic/TestTargetCommand.py
    M lldb/packages/Python/lldbsuite/test/lang/c/global_variables/TestGlobalVariables.py
    M lldb/packages/Python/lldbsuite/test/lldbtest.py

  Log Message:
  -----------
  Re-land "[lldb/Test] Make substrs argument to self.expect ordered."

Re-landing this now that (hopefully) all the failures this caused on the
bots have been addressed.

This patch changes the behavior of the substrs argument to self.expect.
Currently, the elements of substrs are unordered and as long as the
string appears in the output, the assertion passes.

We can be more precise by requiring that the substrings be ordered in
the way they appear. My hope is that this will make it harder to
accidentally pass a check because a string appears out of order.

Differential revision: https://reviews.llvm.org/D73766