[all-commits] [llvm/llvm-project] 1ced28: DebugInfo: Hash DW_OP_convert in loclists when usi...

[David Blaikie via All-commits]

  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: 1ced28cbe75ff81f35ac2c71e941041eb3afcd00
      https://github.com/llvm/llvm-project/commit/1ced28cbe75ff81f35ac2c71e941041eb3afcd00
  Author: David Blaikie <dblaikie at gmail.com>
  Date:   2020-02-03 (Mon, 03 Feb 2020)

  Changed paths:
    M llvm/lib/CodeGen/AsmPrinter/ByteStreamer.h
    M llvm/lib/CodeGen/AsmPrinter/DwarfDebug.cpp
    M llvm/test/DebugInfo/X86/convert-loclist.ll

  Log Message:
  -----------
  DebugInfo: Hash DW_OP_convert in loclists when using Split DWARF

This code was incorrectly emitting extra bytes into arbitrary parts of
the object file when it was meant to be hashing them to compute the DWO
ID.

Follow-up patch(es) will refactor this API somewhat to make such bugs
harder to introduce, hopefully.