[all-commits] [llvm/llvm-project] 0d6fcc: [GWP-ASan] Allow late initialisation if single-thr...

Mitch Phillips via All-commits all-commits at lists.llvm.org
Mon Feb 3 12:35:00 PST 2020


  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: 0d6fccb460e515a78c33dcd97cda459332ddd63a
      https://github.com/llvm/llvm-project/commit/0d6fccb460e515a78c33dcd97cda459332ddd63a
  Author: Mitch Phillips <31459023+hctim at users.noreply.github.com>
  Date:   2020-02-03 (Mon, 03 Feb 2020)

  Changed paths:
    M compiler-rt/lib/gwp_asan/guarded_pool_allocator.cpp
    M compiler-rt/lib/gwp_asan/tests/CMakeLists.txt
    A compiler-rt/lib/gwp_asan/tests/late_init.cpp

  Log Message:
  -----------
  [GWP-ASan] Allow late initialisation if single-threaded.

Summary:
This patch allows for late initialisation of the GWP-ASan allocator. Previously, if late initialisation occurred, the sample counter was never updated, meaning we would end up having to wait for 2^32 allocations before getting a sampled allocation.

Now, we initialise the sampling mechanism in init() as well. We require init() to be called single-threaded, so this isn't a problem.

Reviewers: eugenis

Reviewed By: eugenis

Subscribers: merge_guards_bot, mgorny, #sanitizers, llvm-commits, cferris

Tags: #sanitizers, #llvm

Differential Revision: https://reviews.llvm.org/D73896




More information about the All-commits mailing list