[all-commits] [llvm/llvm-project] 0ad18b: [llvm-objdump] Suppress spurious warnings when par...

Michael Trent via All-commits all-commits at lists.llvm.org
Mon Feb 3 10:59:41 PST 2020

  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: 0ad18bf37b2d4f6a619f2ebdd6cfbe0ac617a2e5
  Author: Michael Trent <mtrent at apple.com>
  Date:   2020-02-03 (Mon, 03 Feb 2020)

  Changed paths:
    M llvm/test/tools/llvm-objdump/X86/macho-cstring-dump.test
    M llvm/tools/llvm-objdump/MachODump.cpp
    M llvm/tools/llvm-objdump/llvm-objdump.cpp

  Log Message:
  [llvm-objdump] Suppress spurious warnings when parsing Mach-O binaries.

llvm-objdump started warning when asked to disassemble a section that
isn't present in the input files, in Yuanfang Chen's change:
d16c162c9453db855503134fe29ae4a3c0bec936. The problem is that the
logic was restricted only to the generic llvm-objdump parser, not to the
Mach-O-specific parser used for Apple toolchain compatibility. The
solution is to log section names from the Mach-O parser.

The macho-cstring-dump.test has been updated to fail if it encounters
this new warning in the future.

Reviewers: pete, ab, lhames, jhenderson, grimar, MaskRay, ychen

Reviewed By: jhenderson, grimar

Subscribers: rupprecht, llvm-commits

Tags: #llvm

Differential Revision: https://reviews.llvm.org/D73586

More information about the All-commits mailing list