[all-commits] [llvm/llvm-project] dd5056: MSVC Buggy version detection: turn pre-processor e...

Mehdi Amini via All-commits all-commits at lists.llvm.org
Mon Feb 3 04:16:19 PST 2020


  Branch: refs/heads/release/10.x
  Home:   https://github.com/llvm/llvm-project
  Commit: dd50560c38dbdcf1e809f15b4f3c26152f439a03
      https://github.com/llvm/llvm-project/commit/dd50560c38dbdcf1e809f15b4f3c26152f439a03
  Author: Mehdi Amini <aminim at google.com>
  Date:   2020-02-03 (Mon, 03 Feb 2020)

  Changed paths:
    M llvm/cmake/modules/CheckCompilerVersion.cmake

  Log Message:
  -----------
  MSVC Buggy version detection: turn pre-processor error into CMake configuration time check

This allows consumer to override in a cleaner way while still prevent
them from hitting bug without knowing they run an unsupported
configuration.

Recommit after fix by Christopher Tetreault to add parens and ${} to
cmake check to work around CMake configure time "unknown arguments
specified" issue

Differential Revision: https://reviews.llvm.org/D73677
Differential Revision: https://reviews.llvm.org/D73751

(cherry picked from commit 5f940220bf9438e95ffa4a627ac1591be1e1ba6e)




More information about the All-commits mailing list