[all-commits] [llvm/llvm-project] 5a56a2: [CodeGenPrepare] Make TargetPassConfig required

Fangrui Song via All-commits all-commits at lists.llvm.org
Sun Feb 2 09:28:55 PST 2020


  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: 5a56a25b0bd1279c41604a64c6a1bec3815b9b36
      https://github.com/llvm/llvm-project/commit/5a56a25b0bd1279c41604a64c6a1bec3815b9b36
  Author: Fangrui Song <maskray at google.com>
  Date:   2020-02-02 (Sun, 02 Feb 2020)

  Changed paths:
    M llvm/lib/CodeGen/CodeGenPrepare.cpp
    M llvm/test/CodeGen/AArch64/sve-vscale.ll
    R llvm/test/CodeGen/Generic/dont-remove-empty-preheader.ll
    M llvm/test/CodeGen/PowerPC/splitstore-check-volatile.ll
    A llvm/test/CodeGen/X86/dont-remove-empty-preheader.ll
    R llvm/test/DebugInfo/Generic/codegenprep-value.ll
    R llvm/test/DebugInfo/Generic/sunk-compare.ll
    A llvm/test/DebugInfo/X86/codegenprep-value.ll
    A llvm/test/DebugInfo/X86/sunk-compare.ll
    M llvm/test/Other/2007-04-24-eliminate-mostly-empty-blocks.ll
    A llvm/test/Transforms/CodeGenPrepare/X86/bitreverse-hang.ll
    A llvm/test/Transforms/CodeGenPrepare/X86/gep-unmerging.ll
    A llvm/test/Transforms/CodeGenPrepare/X86/invariant.group.ll
    M llvm/test/Transforms/CodeGenPrepare/X86/memset_chk-simplify-nobuiltin.ll
    A llvm/test/Transforms/CodeGenPrepare/X86/split-indirect-loop.ll
    A llvm/test/Transforms/CodeGenPrepare/X86/widenable-condition.ll
    R llvm/test/Transforms/CodeGenPrepare/bitreverse-hang.ll
    R llvm/test/Transforms/CodeGenPrepare/gep-unmerging.ll
    R llvm/test/Transforms/CodeGenPrepare/invariant.group.ll
    R llvm/test/Transforms/CodeGenPrepare/split-indirect-loop.ll
    R llvm/test/Transforms/CodeGenPrepare/widenable-condition.ll

  Log Message:
  -----------
  [CodeGenPrepare] Make TargetPassConfig required

The code paths in the absence of TargetMachine, TargetLowering or
TargetRegisterInfo are poorly tested. As rL285987 said, requiring
TargetPassConfig allows us to delete many (untested) checks littered
everywhere.

Reviewed By: arsenm

Differential Revision: https://reviews.llvm.org/D73754




More information about the All-commits mailing list