[all-commits] [llvm/llvm-project] d82e99: [ADT] 'PointerUnion::is' returns 'bool'

[Brian Gesiak via All-commits]

  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: d82e993cd34ae6fda1eeb57c1b4d3d2629960664
      https://github.com/llvm/llvm-project/commit/d82e993cd34ae6fda1eeb57c1b4d3d2629960664
  Author: Brian Gesiak <modocache at gmail.com>
  Date:   2020-02-01 (Sat, 01 Feb 2020)

  Changed paths:
    M llvm/include/llvm/ADT/PointerUnion.h

  Log Message:
  -----------
  [ADT] 'PointerUnion::is' returns 'bool'

Summary:
The return type of 'PointerUnion::is' has been 'int' since it was first
added in March 2009, in SVN r67987, or
https://github.com/llvm/llvm-project/commit/a9c6de15fb3.

The only other change to this member function was a clang-format applied
in December 2015, in SVN r256513, or
https://github.com/llvm/llvm-project/commit/548a49aacc0.

However, since the return value is the result of a `==` comparison, an
implicit cast must be made converting the boolean result to an `int`.
Change the return type to `bool` to remove the need for such a cast.

Test Plan:
I ran llvm-project `check-all` under ASAN, no failures were reported
(other than obviously unrelated tests that were already failing in
ASAN buildbots).

Reviewers: gribozavr, gribozavr2, rsmith, bkramer, dblaikie

Subscribers: dexonsmith, llvm-commits

Tags: #llvm

Differential Revision: https://reviews.llvm.org/D73836