[all-commits] [llvm/llvm-project] a57dd6: [X86] In X86FastEmitSSESelect, fall back to Select...

topperc via All-commits all-commits at lists.llvm.org
Sat Feb 1 12:37:23 PST 2020


  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: a57dd66d5e1c7e2514d42afdcb74566b76552e60
      https://github.com/llvm/llvm-project/commit/a57dd66d5e1c7e2514d42afdcb74566b76552e60
  Author: Craig Topper <craig.topper at gmail.com>
  Date:   2020-02-01 (Sat, 01 Feb 2020)

  Changed paths:
    M llvm/lib/Target/X86/X86FastISel.cpp
    A llvm/test/CodeGen/X86/pr44749.ll

  Log Message:
  -----------
  [X86] In X86FastEmitSSESelect, fall back to SelectionDAG if the inputs to the compare can't be found in registers.

We were checking that the original Value * for the compare operands
were null. But that can never happen.

I believe we intended to check for 0 registers here instead.

Fixes PR44749.




More information about the All-commits mailing list