[all-commits] [llvm/llvm-project] cad910: [InstCombine] Create new insts in foldICmpEqIntrin...

Nikita Popov via All-commits all-commits at lists.llvm.org
Thu Jan 30 14:14:31 PST 2020


  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: cad91074a65ef992a230f071b77912e42eb1a908
      https://github.com/llvm/llvm-project/commit/cad91074a65ef992a230f071b77912e42eb1a908
  Author: Nikita Popov <nikita.ppv at gmail.com>
  Date:   2020-01-30 (Thu, 30 Jan 2020)

  Changed paths:
    M llvm/lib/Transforms/InstCombine/InstCombineCompares.cpp

  Log Message:
  -----------
  [InstCombine] Create new insts in foldICmpEqIntrinsicWithConstant; NFCI

In line with current conventions, create new instructions rather
than modify two operands in place and performing manual worklist
management.

This should be NFC apart from possible worklist order changes.


  Commit: 90b5ed996bfa97beb9cb96e013913cc956540b95
      https://github.com/llvm/llvm-project/commit/90b5ed996bfa97beb9cb96e013913cc956540b95
  Author: Nikita Popov <nikita.ppv at gmail.com>
  Date:   2020-01-30 (Thu, 30 Jan 2020)

  Changed paths:
    M llvm/lib/Transforms/InstCombine/InstCombineCompares.cpp

  Log Message:
  -----------
  [InstCombine] Remove unnecessary worklist add; NFCI

The IRBuilder will automatically add instructions to the worklist.
Adding it manually is unnecessary, but may mess up worklist order.


Compare: https://github.com/llvm/llvm-project/compare/01943a59f51d...90b5ed996bfa


More information about the All-commits mailing list