[all-commits] [llvm/llvm-project] a36093: [Concept] Fix incorrect check for containsUnexpand...

[Saar Raz via All-commits]

  Branch: refs/heads/release/10.x
  Home:   https://github.com/llvm/llvm-project
  Commit: a3609357f3888685f5d864d5708421b0993650b8
      https://github.com/llvm/llvm-project/commit/a3609357f3888685f5d864d5708421b0993650b8
  Author: Saar Raz <saar at raz.email>
  Date:   2020-01-30 (Thu, 30 Jan 2020)

  Changed paths:
    M clang/include/clang/AST/ExprConcepts.h
    M clang/lib/AST/ASTContext.cpp
    M clang/lib/AST/ExprConcepts.cpp
    M clang/test/CXX/expr/expr.prim/expr.prim.id/p3.cpp

  Log Message:
  -----------
  [Concept] Fix incorrect check for containsUnexpandedParameterPack in CSE

We previously checked for containsUnexpandedParameterPack in CSEs by observing the property
in the converted arguments of the CSE. This may not work if the argument is an expanded
type-alias that contains a pack-expansion (see added test).

Check the as-written arguments when determining containsUnexpandedParameterPack and isInstantiationDependent.

(cherry picked from commit c83d9bedc0cc430dc620e7a807daeb985d390325)


  Commit: 6c6ea5995f261f0baa2be8a216ad08186551c622
      https://github.com/llvm/llvm-project/commit/6c6ea5995f261f0baa2be8a216ad08186551c622
  Author: Saar Raz <saar at raz.email>
  Date:   2020-01-30 (Thu, 30 Jan 2020)

  Changed paths:
    M clang/lib/Sema/SemaConcept.cpp
    M clang/lib/Sema/SemaExpr.cpp

  Log Message:
  -----------
  [Concepts] Add check for dependent RC when checking function constraints

Do not attempt to check a dependent requires clause in a function constraint
(may be triggered by, for example, DiagnoseUseOfDecl).

(cherry picked from commit a424ef99e7b9821ec80564af3d3a8f091323a38c)


  Commit: 800395c54754c04a761b1bb6360bb4b2dc2935f4
      https://github.com/llvm/llvm-project/commit/800395c54754c04a761b1bb6360bb4b2dc2935f4
  Author: Saar Raz <saar at raz.email>
  Date:   2020-01-30 (Thu, 30 Jan 2020)

  Changed paths:
    M clang/lib/Sema/SemaTemplateInstantiateDecl.cpp

  Log Message:
  -----------
  [Concepts] Add 'this' context to instantiation of member requires clause

'this' context was missing in instantiation of member requires clause.

(cherry picked from commit 60f5da79e3de49b2074446e656a72970499a8d78)


Compare: https://github.com/llvm/llvm-project/compare/e5123472201e...800395c54754