[all-commits] [llvm/llvm-project] addc27: Changed wrong ROCDL instructions in GPU lowering.

dfki-jugr via All-commits all-commits at lists.llvm.org
Thu Jan 30 06:37:26 PST 2020


  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: addc27bc437d2fb1f31d88294b227ac32be63cc5
      https://github.com/llvm/llvm-project/commit/addc27bc437d2fb1f31d88294b227ac32be63cc5
  Author: Julian Gross <julian.gross at dfki.de>
  Date:   2020-01-30 (Thu, 30 Jan 2020)

  Changed paths:
    M mlir/lib/Conversion/GPUToROCDL/LowerGpuOpsToROCDLOps.cpp
    M mlir/test/Conversion/GPUToROCDL/gpu-to-rocdl.mlir

  Log Message:
  -----------
  Changed wrong ROCDL instructions in GPU lowering.

Summary:
In the scope of the lowering phase from GPU to ROCDL, the intructions for the conversion patterns seems to be wrong.
According to https://github.com/ROCm-Developer-Tools/HIP/blob/master/include/hip/hcc_detail/math_fwd.h the instructions need two underscores in the beginning instead of one.

Reviewers: nicolasvasilache, herhut, rriddle

Reviewed By: herhut, rriddle

Subscribers: merge_guards_bot, mehdi_amini, rriddle, jpienaar, burmako, shauheen, antiagainst, csigg, arpith-jacob, mgester, lucyrfox, herhut, liufengdb, llvm-commits

Tags: #llvm

Differential Revision: https://reviews.llvm.org/D73535




More information about the All-commits mailing list