[all-commits] [llvm/llvm-project] 2e745b: [runtimes] Fix passing lists to runtimes configures

[Shoaib Meenai via All-commits]

  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: 2e745ba6b0baa1083d64e7363743ba9457ebd187
      https://github.com/llvm/llvm-project/commit/2e745ba6b0baa1083d64e7363743ba9457ebd187
  Author: Shoaib Meenai <smeenai at fb.com>
  Date:   2020-01-28 (Tue, 28 Jan 2020)

  Changed paths:
    M llvm/runtimes/CMakeLists.txt

  Log Message:
  -----------
  [runtimes] Fix passing lists to runtimes configures

We have to replace the ";" with "|" (since LLVMExternalProjectUtils uses
"|" as the `LIST_SEPARATOR` when invoking `ExternalProject_Add`) in
order for lists to be passed correctly to the runtimes CMake configures.
Remove the special case for `LLVM_ENABLE_RUNTIMES`, since it'll just get
handled by the general logic now.

Differential Revision: https://reviews.llvm.org/D73512


  Commit: d8f6950828df9959c84a659377214266d64be68e
      https://github.com/llvm/llvm-project/commit/d8f6950828df9959c84a659377214266d64be68e
  Author: Shoaib Meenai <smeenai at fb.com>
  Date:   2020-01-28 (Tue, 28 Jan 2020)

  Changed paths:
    M compiler-rt/lib/asan/tests/asan_test.cpp

  Log Message:
  -----------
  [asan] Fix test compilation on Android API <= 17

mlockall and munlockall were introduced in Android API 17, so avoid
referencing them on prior versions.

Differential Revision: https://reviews.llvm.org/D73515


  Commit: 076da521f31a48c2154ab9c03c004afaad70a53b
      https://github.com/llvm/llvm-project/commit/076da521f31a48c2154ab9c03c004afaad70a53b
  Author: Shoaib Meenai <smeenai at fb.com>
  Date:   2020-01-28 (Tue, 28 Jan 2020)

  Changed paths:
    M libcxx/CMakeLists.txt
    M libcxxabi/src/CMakeLists.txt

  Log Message:
  -----------
  [libcxx] Link against android_support when needed

libc++ on Android needs to be linked against libandroid_support on API
levels less than 21 to provide needed functions that aren't in the libc
on those platforms (e.g. posix_memalign for libcxxabi). libc++ from the
NDK is a linker script that pulls in libandroid_support, but for
building libc++ itself, we need to explicitly add libandroid_support as
a dependency. Moreover, libc++ headers reference the functions provided
by libandroid_support, so it needs to be added as a public dependency.

Differential Revision: https://reviews.llvm.org/D73516


Compare: https://github.com/llvm/llvm-project/compare/adcd02683856...076da521f31a