[all-commits] [llvm/llvm-project] 5eaf44: [lldb] Delete ValueObject::GetBaseClassPath

Alex via All-commits all-commits at lists.llvm.org
Tue Jan 28 14:12:14 PST 2020


  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: 5eaf44f99f0a0a3bdfa892892b8aaca841c8dbe0
      https://github.com/llvm/llvm-project/commit/5eaf44f99f0a0a3bdfa892892b8aaca841c8dbe0
  Author: Alex Langford <apl at fb.com>
  Date:   2020-01-28 (Tue, 28 Jan 2020)

  Changed paths:
    M lldb/include/lldb/Core/ValueObject.h
    M lldb/source/Core/ValueObject.cpp

  Log Message:
  -----------
  [lldb] Delete ValueObject::GetBaseClassPath

Summary:
This method has exactly one call site, which is only actually executed
if `ValueObject::IsBaseClass` returns false. However, the first thing
that `ValueObject::GetBaseClassPath` does is check if `ValueObject::IsBaseClass`
is true. Because this can never be the case, this method always returns false
and is therefore effectively dead.

Differential Revision: https://reviews.llvm.org/D73517




More information about the All-commits mailing list