[all-commits] [llvm/llvm-project] 04488c: Don't fail step out if remote server doesn't imple...

[tedwoodward via All-commits]

  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: 04488c485a8875ba4bd6d2d004ac778276ae37e0
      https://github.com/llvm/llvm-project/commit/04488c485a8875ba4bd6d2d004ac778276ae37e0
  Author: Ted Woodward <ted.woodward at codeaurora.org>
  Date:   2020-01-28 (Tue, 28 Jan 2020)

  Changed paths:
    M lldb/source/Target/ThreadPlanStepOut.cpp

  Log Message:
  -----------
  Don't fail step out if remote server doesn't implement qMemoryRegionInfo

Summary:
The return address validation in D71372 will fail if the memory permissions can't be determined. Many embedded stubs either don't implement the qMemoryRegionInfo packet, or don't have memory permissions at all.

Remove the return from the if clause that calls GetLoadAddressPermissions, so this call failing doesn't cause the step out to abort. Instead, assume that the memory permission check doesn't apply to this type of target.

Reviewers: labath, jingham, clayborg, mossberg

Reviewed By: labath

Subscribers: lldb-commits

Tags: #lldb

Differential Revision: https://reviews.llvm.org/D72513