[all-commits] [llvm/llvm-project] 57839e: [llvm-dwarfdump][Statistics] Count more than one c...

chbessonova via All-commits all-commits at lists.llvm.org
Tue Jan 28 10:56:30 PST 2020


  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: 57839e51781567e320e6a55bafa5afee3335bebe
      https://github.com/llvm/llvm-project/commit/57839e51781567e320e6a55bafa5afee3335bebe
  Author: Kristina Bessonova <kbessonova at accesssoftek.com>
  Date:   2020-01-28 (Tue, 28 Jan 2020)

  Changed paths:
    A llvm/test/tools/llvm-dwarfdump/X86/stats-mulitple-cu-out-of-line.ll
    M llvm/tools/llvm-dwarfdump/Statistics.cpp

  Log Message:
  -----------
  [llvm-dwarfdump][Statistics] Count more than one conrete out-of-line instances of a function

Here may be more than one out-of-line instance of the same function
among different CUs. All of them should be accounted for to get an accurate
total number of variables/parameters.

Reviewed by: aprantl

Differential Revision: https://reviews.llvm.org/D73002


  Commit: 5499e2f455caad5c7cf95aa459b8d246e14c6af9
      https://github.com/llvm/llvm-project/commit/5499e2f455caad5c7cf95aa459b8d246e14c6af9
  Author: Kristina Bessonova <kbessonova at accesssoftek.com>
  Date:   2020-01-28 (Tue, 28 Jan 2020)

  Changed paths:
    M llvm/test/tools/llvm-dwarfdump/X86/statistics.ll
    M llvm/tools/llvm-dwarfdump/Statistics.cpp

  Log Message:
  -----------
  [llvm-dwarfdump][Statistics] Distinguish parameters with same name or w/o a name

A few DW_TAG_formal_parameter's of the same function may have the same
name (e.g. variadic (template) functions) or don't have a name at all
(if the parameter isn't used inside the function body), but we still
need to be able to distinguish between them to get correct number of 'total vars'
and 'availability' metric.

Reviewed by: aprantl

Differential Revision: https://reviews.llvm.org/D73003


  Commit: 4b0a7fe008e6a61997f622b7993d6316d898deae
      https://github.com/llvm/llvm-project/commit/4b0a7fe008e6a61997f622b7993d6316d898deae
  Author: Kristina Bessonova <kbessonova at accesssoftek.com>
  Date:   2020-01-28 (Tue, 28 Jan 2020)

  Changed paths:
    A llvm/test/tools/llvm-dwarfdump/X86/stats-multiple-cu-members.ll
    M llvm/tools/llvm-dwarfdump/Statistics.cpp

  Log Message:
  -----------
  [llvm-dwarfdump][Statistics] Make calculations of vars in global scope more accurate

It isn't known how many times we've seen the same variable or member in
the global scope (unlike in functions), but there still can be some duplicates
among different CUs.
So, this patch proposes to count variables in the global scope just as a sum of
the number of vars, constant members and artificial entities.

Reviewed by: aprantl

Differential Revision: https://reviews.llvm.org/D73004


Compare: https://github.com/llvm/llvm-project/compare/276a6b88898a...4b0a7fe008e6


More information about the All-commits mailing list