[all-commits] [llvm/llvm-project] 9806b3: [llvm-dwarfdump][Statistics] Distinguish functions...

[chbessonova via All-commits]

  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: 9806b39dae18982864dc3d9cdb2871d9590e5408
      https://github.com/llvm/llvm-project/commit/9806b39dae18982864dc3d9cdb2871d9590e5408
  Author: Kristina Bessonova <kbessonova at accesssoftek.com>
  Date:   2020-01-28 (Tue, 28 Jan 2020)

  Changed paths:
    A llvm/test/tools/llvm-dwarfdump/X86/stats-multiple-cu-same-name.ll
    M llvm/tools/llvm-dwarfdump/Statistics.cpp

  Log Message:
  -----------
  [llvm-dwarfdump][Statistics] Distinguish functions/variables with same name across different CUs

Different variables and functions might have the same name in different CU.
To calculate 'Availability' metric more accurate (i.e. to avoid getting
availability above 100%), we need to have some additional logic to
distinguish between them.

The patch introduces a DIE identifier that consists of a function/variable name
and declaration information: a filename and a line number. This allows
distinguishing different functions/variables (different means declared in
different files/lines) with the same name, keeping duplicates counted
as duplicates.

Reviewed by: aprantl, djtodoro

Differential Revision: https://reviews.llvm.org/D72797


  Commit: e76106e01c4b79894ac9c28e48e786121e1cdb6c
      https://github.com/llvm/llvm-project/commit/e76106e01c4b79894ac9c28e48e786121e1cdb6c
  Author: Kristina Bessonova <kbessonova at accesssoftek.com>
  Date:   2020-01-28 (Tue, 28 Jan 2020)

  Changed paths:
    M llvm/test/tools/llvm-dwarfdump/X86/statistics.ll
    M llvm/tools/llvm-dwarfdump/Statistics.cpp

  Log Message:
  -----------
  [llvm-dwarfdump][Statistics] Ignore DW_TAG_subroutine_type in statistics

DW_TAG_subroutine_type is not really useful for statistics purposes, as it never
has location information. But it may contain DW_TAG_formal_parameter
children that generate number of parameters w/o location and decrease
'availability' metric significantly.

Reviewed by: djtodoro

Differential Revision: https://reviews.llvm.org/D72983


  Commit: 2e5d20bd478868c80aa595e969d17734690f9b4d
      https://github.com/llvm/llvm-project/commit/2e5d20bd478868c80aa595e969d17734690f9b4d
  Author: Kristina Bessonova <kbessonova at accesssoftek.com>
  Date:   2020-01-28 (Tue, 28 Jan 2020)

  Changed paths:
    M llvm/test/tools/llvm-dwarfdump/X86/statistics.ll
    M llvm/tools/llvm-dwarfdump/Statistics.cpp

  Log Message:
  -----------
  [llvm-dwarfdump][Statistics] Ignore declarations of global variables

Reviewed by: djtodoro

Differential Revision: https://reviews.llvm.org/D73001


Compare: https://github.com/llvm/llvm-project/compare/a928d127a52a...2e5d20bd4788