[all-commits] [llvm/llvm-project] ab9e55: [mlir] Refactor the implementation of Symbol use l...

River Riddle via All-commits all-commits at lists.llvm.org
Mon Jan 27 23:10:07 PST 2020


  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: ab9e5598cdc793890f514c2756866c53ad7971f3
      https://github.com/llvm/llvm-project/commit/ab9e5598cdc793890f514c2756866c53ad7971f3
  Author: River Riddle <riddleriver at gmail.com>
  Date:   2020-01-27 (Mon, 27 Jan 2020)

  Changed paths:
    M mlir/include/mlir/IR/SymbolTable.h
    M mlir/lib/IR/SymbolTable.cpp
    M mlir/test/lib/IR/TestSymbolUses.cpp

  Log Message:
  -----------
  [mlir] Refactor the implementation of Symbol use lists.

Summary: This revision refactors the implementation of the symbol use-list functionality to be a bit cleaner, as well as easier to reason about. Aside from code cleanup, this revision updates the user contract to never recurse into operations if they define a symbol table. The current functionality, which does recurse, makes it difficult to examine the uses held by a symbol table itself. Moving forward users may provide a specific region to examine for uses instead.

Differential Revision: https://reviews.llvm.org/D73427




More information about the All-commits mailing list