[all-commits] [llvm/llvm-project] d2a973: AMDGPU/GlobalISel: Eliminate SelectVOP3Mods_f32

[Matt Arsenault via All-commits]

  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: d2a9739274f687971d0283a18c4ed58af81394f4
      https://github.com/llvm/llvm-project/commit/d2a9739274f687971d0283a18c4ed58af81394f4
  Author: Matt Arsenault <Matthew.Arsenault at amd.com>
  Date:   2020-01-27 (Mon, 27 Jan 2020)

  Changed paths:
    M llvm/lib/Target/AMDGPU/AMDGPUISelDAGToDAG.cpp
    M llvm/lib/Target/AMDGPU/AMDGPUInstructionSelector.cpp
    M llvm/lib/Target/AMDGPU/SIInstrInfo.td
    M llvm/lib/Target/AMDGPU/SIInstructions.td
    M llvm/test/CodeGen/AMDGPU/GlobalISel/inst-select-select.mir

  Log Message:
  -----------
  AMDGPU/GlobalISel: Eliminate SelectVOP3Mods_f32

Trivial type predicates should be moved into the tablegen pattern
itself, and not checked inside complex patterns. This eliminates a
redundant complex pattern, and fixes select source modifiers for
GlobalISel.

I have further patches which fully handle select in tablegen and
remove all of the C++ selection, although it requires the ugliness to
support the entire range of legal register types.