[all-commits] [llvm/llvm-project] ef9174: [clangd] Show hower info for expressions

Mon Jan 27 07:40:01 PST 2020

  Branch: refs/heads/release/10.x
  Home:   https://github.com/llvm/llvm-project
  Commit: ef917463d9c0982e0aa6c6f2786ad0ae8a8e2637
      https://github.com/llvm/llvm-project/commit/ef917463d9c0982e0aa6c6f2786ad0ae8a8e2637
  Author: Kadir Cetinkaya <kadircet at google.com>
  Date:   2020-01-27 (Mon, 27 Jan 2020)

  Changed paths:
    M clang-tools-extra/clangd/Hover.cpp
    M clang-tools-extra/clangd/unittests/HoverTests.cpp

  Log Message:
  -----------
  [clangd] Show hower info for expressions

Summary:
This currently populates only the Name with the expression's type and
Value if expression is evaluatable.

Fixes https://github.com/clangd/clangd/issues/56

Reviewers: sammccall

Subscribers: ilya-biryukov, MaskRay, jkorous, arphaman, usaxena95, cfe-commits

Tags: #clang

Differential Revision: https://reviews.llvm.org/D72500

(cherry picked from commit 4d14bfaa2cb1610104db6b0818fc7d74fad1bd8f)

  Commit: a6f550eae718862496f6ba01b0b618ee9326eceb
      https://github.com/llvm/llvm-project/commit/a6f550eae718862496f6ba01b0b618ee9326eceb
  Author: Kadir Cetinkaya <kadircet at google.com>
  Date:   2020-01-27 (Mon, 27 Jan 2020)

  Changed paths:
    M clang-tools-extra/clangd/FormattedString.cpp
    M clang-tools-extra/clangd/FormattedString.h
    M clang-tools-extra/clangd/Hover.cpp
    M clang-tools-extra/clangd/unittests/FormattedStringTests.cpp
    M clang-tools-extra/clangd/unittests/HoverTests.cpp

  Log Message:
  -----------
  [clangd] Add a ruler after header in hover

Reviewers: sammccall

Subscribers: ilya-biryukov, MaskRay, jkorous, arphaman, usaxena95, cfe-commits

Tags: #clang

Differential Revision: https://reviews.llvm.org/D72622

(cherry picked from commit d74a3d470c316f8fade90fe231fc0a51361c01e6)

  Commit: 13553d51aa87f5a66a1c9da5ca2abb3d9ebd9ae2
      https://github.com/llvm/llvm-project/commit/13553d51aa87f5a66a1c9da5ca2abb3d9ebd9ae2
  Author: Kadir Cetinkaya <kadircet at google.com>
  Date:   2020-01-27 (Mon, 27 Jan 2020)

  Changed paths:
    M clang-tools-extra/clangd/Hover.cpp
    M clang-tools-extra/clangd/test/hover.test
    M clang-tools-extra/clangd/unittests/HoverTests.cpp

  Log Message:
  -----------
  [clangd] Rearrange type, returntype and parameters in hover card

Summary:
Moves type/returntype into its own line as it is more readable in cases
where the type is long.

Also gives parameter lists a heading, `Parameters:` to make them stand out.

Leaves the `right arrow` instead of `Returns: ` before Return Type to make
output more symmetric.

```
function foo

Returns: ret_type
Parameters:
- int x
```

vs

```
function foo

🡺 ret_type
Parameters:
- int x
```

Reviewers: sammccall, ilya-biryukov

Subscribers: MaskRay, jkorous, arphaman, usaxena95, cfe-commits

Tags: #clang

Differential Revision: https://reviews.llvm.org/D72623

(cherry picked from commit 44f9c7a820c1e5fb949f441214a46b13588ff51a)

  Commit: a27142b26a584a1d0bdbcc7ed2b4b386418a96ee
      https://github.com/llvm/llvm-project/commit/a27142b26a584a1d0bdbcc7ed2b4b386418a96ee
  Author: Kadir Cetinkaya <kadircet at google.com>
  Date:   2020-01-27 (Mon, 27 Jan 2020)

  Changed paths:
    M clang-tools-extra/clangd/unittests/HoverTests.cpp

  Log Message:
  -----------
  [clangd] Fix windows buildbots

(cherry picked from commit 60adfb83cda883d9fc1079c89d2feaa681a41b90)

  Commit: 1f448807c2ef24ffe0fde19fdd2fc46556436a5c
      https://github.com/llvm/llvm-project/commit/1f448807c2ef24ffe0fde19fdd2fc46556436a5c
  Author: Kadir Cetinkaya <kadircet at google.com>
  Date:   2020-01-27 (Mon, 27 Jan 2020)

  Changed paths:
    M clang-tools-extra/clangd/unittests/HoverTests.cpp

  Log Message:
  -----------
  [clangd] Extract string literals in macro arguments to unbreak gcc buildbots

(cherry picked from commit 041650da67051266eb92b5bb07223394fe1bdab1)

  Commit: 7350a0429cc77947abba1591839a7a652af66623
      https://github.com/llvm/llvm-project/commit/7350a0429cc77947abba1591839a7a652af66623
  Author: Kadir Cetinkaya <kadircet at google.com>
  Date:   2020-01-27 (Mon, 27 Jan 2020)

  Changed paths:
    M clang-tools-extra/clangd/Hover.cpp
    M clang-tools-extra/clangd/unittests/HoverTests.cpp

  Log Message:
  -----------
  [clangd] Dont display `<unknown>` kinds in hover board

Summary:
Currently when hovering over an `auto` or `decltype` that resolve to a
builtin-type, clangd would display `<unknown>` as the kind of the symbol.

Drop that to make rendering nicer.

Reviewers: usaxena95

Subscribers: ilya-biryukov, MaskRay, jkorous, arphaman, cfe-commits

Tags: #clang

Differential Revision: https://reviews.llvm.org/D72777

(cherry picked from commit b08e8353a89f682861ef947fdb6e229b3de2e37d)

  Commit: 1426bb44cc777fbbd867a1eaeb25d6460a99214c
      https://github.com/llvm/llvm-project/commit/1426bb44cc777fbbd867a1eaeb25d6460a99214c
  Author: Kadir Cetinkaya <kadircet at google.com>
  Date:   2020-01-27 (Mon, 27 Jan 2020)

  Changed paths:
    M clang-tools-extra/clangd/Hover.cpp
    M clang-tools-extra/clangd/unittests/HoverTests.cpp

  Log Message:
  -----------
  [clangd] Print underlying type for decltypes in hover

Summary: Fixes https://github.com/clangd/clangd/issues/249

Reviewers: sammccall

Subscribers: ilya-biryukov, MaskRay, jkorous, arphaman, usaxena95, cfe-commits

Tags: #clang

Differential Revision: https://reviews.llvm.org/D72498

(cherry picked from commit 0474fe465d8feebcfd54a16d93ad8518b5625972)

  Commit: 53f39c77b2ba74626b0dfd5efbfdf39b2f0d720e
      https://github.com/llvm/llvm-project/commit/53f39c77b2ba74626b0dfd5efbfdf39b2f0d720e
  Author: Kadir Cetinkaya <kadircet at google.com>
  Date:   2020-01-27 (Mon, 27 Jan 2020)

  Changed paths:
    M clang-tools-extra/clangd/Hover.cpp
    M clang-tools-extra/clangd/unittests/HoverTests.cpp

  Log Message:
  -----------
  [clangd] Drop returntype/type when hovering over type-ish names

Summary:
Some names, e.g. constructor/destructor/conversions, already contain
the type info, no need to duplicate them in the hoverinfo.

Fixes https://github.com/clangd/clangd/issues/252

Reviewers: sammccall, ilya-biryukov

Subscribers: MaskRay, jkorous, arphaman, usaxena95, cfe-commits

Tags: #clang

Differential Revision: https://reviews.llvm.org/D73110

(cherry picked from commit 1fbb1d6df0113ca341f6d257bc72e07343dd861a)

  Commit: 99464b7eb1d7bbeb7380a6ccc19b0ffdb2f08d40
      https://github.com/llvm/llvm-project/commit/99464b7eb1d7bbeb7380a6ccc19b0ffdb2f08d40
  Author: Kadir Cetinkaya <kadircet at google.com>
  Date:   2020-01-27 (Mon, 27 Jan 2020)

  Changed paths:
    M clang-tools-extra/clangd/Hover.cpp
    M clang-tools-extra/clangd/test/hover.test
    M clang-tools-extra/clangd/unittests/HoverTests.cpp

  Log Message:
  -----------
  [clangd][Hover] Change arrow in return type back to →

Summary:
Currently 🡺 is used in hover response to represent return types, but it
is not widely available. Changing this back to original to support more clients.

Reviewers: sammccall

Subscribers: ilya-biryukov, MaskRay, jkorous, arphaman, usaxena95, cfe-commits

Tags: #clang

Differential Revision: https://reviews.llvm.org/D73336

(cherry picked from commit 1b996faa1575bda6b99e778aaabe14834c10d3ff)

Compare: https://github.com/llvm/llvm-project/compare/256a0eaf23b2...99464b7eb1d7