[all-commits] [llvm/llvm-project] 548553: [DWARF] Simplify DWARFExpression. NFC.

[Igor Kudrin via All-commits]

  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: 548553eac7b5c9fafd63c56b0304f35c911dd9fc
      https://github.com/llvm/llvm-project/commit/548553eac7b5c9fafd63c56b0304f35c911dd9fc
  Author: Igor Kudrin <ikudrin at accesssoftek.com>
  Date:   2020-01-27 (Mon, 27 Jan 2020)

  Changed paths:
    M llvm/lib/DebugInfo/DWARF/DWARFExpression.cpp

  Log Message:
  -----------
  [DWARF] Simplify DWARFExpression. NFC.

As DataExtractor already has a method to extract an unsigned value of
a specified size, there is no need to duplicate that.

Differential Revision: https://reviews.llvm.org/D73263


  Commit: 8f3d47c54ac21f99b25d8ad00598b7f5be00d6d8
      https://github.com/llvm/llvm-project/commit/8f3d47c54ac21f99b25d8ad00598b7f5be00d6d8
  Author: Igor Kudrin <ikudrin at accesssoftek.com>
  Date:   2020-01-27 (Mon, 27 Jan 2020)

  Changed paths:
    M llvm/include/llvm/DebugInfo/DWARF/DWARFExpression.h
    M llvm/lib/CodeGen/AsmPrinter/DwarfDebug.cpp
    M llvm/lib/DWARFLinker/DWARFLinker.cpp
    M llvm/lib/DebugInfo/DWARF/DWARFDebugFrame.cpp
    M llvm/lib/DebugInfo/DWARF/DWARFDebugLoc.cpp
    M llvm/lib/DebugInfo/DWARF/DWARFDie.cpp
    M llvm/lib/DebugInfo/DWARF/DWARFExpression.cpp
    M llvm/lib/DebugInfo/DWARF/DWARFVerifier.cpp
    A llvm/test/DebugInfo/X86/DW_OP_call_ref_ver2.s
    M llvm/tools/llvm-dwarfdump/Statistics.cpp

  Log Message:
  -----------
  [DWARF] Do not pass Version to DWARFExpression. NFCI.

The Version was used only to determine the size of an operand of
DW_OP_call_ref. The size was 4 for all versions apart from 2, but
the DW_OP_call_ref operation was introduced only in DWARF3. Thus,
the code may be simplified and using of Version may be eliminated.

Differential Revision: https://reviews.llvm.org/D73264


Compare: https://github.com/llvm/llvm-project/compare/36a8f7f6d8f5...8f3d47c54ac2