[all-commits] [llvm/llvm-project] 91d665: [mlir][spirv] NFC: expose builtin func op conversi...

[Lei Zhang via All-commits]

  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: 91d6655a296f847d6b8d1f11e256b194b7f0d3f9
      https://github.com/llvm/llvm-project/commit/91d6655a296f847d6b8d1f11e256b194b7f0d3f9
  Author: Lei Zhang <antiagainst at google.com>
  Date:   2020-01-26 (Sun, 26 Jan 2020)

  Changed paths:
    M mlir/include/mlir/Dialect/SPIRV/SPIRVLowering.h
    M mlir/lib/Conversion/StandardToSPIRV/ConvertStandardToSPIRVPass.cpp
    M mlir/lib/Dialect/SPIRV/SPIRVLowering.cpp

  Log Message:
  -----------
  [mlir][spirv] NFC: expose builtin func op conversion pattern

This commit exposes the func op conversion pattern via a new
`populateBuiltinFuncToSPIRVPatterns` function from the standard
to SPIR-V conversion passs. This is structurally better given
that func op belongs to the builtin dialect. More importantly,
this makes the pattern reusable to other dialect to SPIR-V
dialect conversion as other dialect can well adopt builtin
func op instead of having its own. Besides, it's very common
to use func ops as test wrappers in lit tests, so test passes
will need to handle func ops too.

Differential Revision: https://reviews.llvm.org/D73421