[all-commits] [llvm/llvm-project] 9902c8: [lldb/debugserver] Unify the breakpoint/watchpoint...

[Jonas Devlieghere via All-commits]

  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: 9902c8e3c6615185a8a00325fa4671c63b61d535
      https://github.com/llvm/llvm-project/commit/9902c8e3c6615185a8a00325fa4671c63b61d535
  Author: Jonas Devlieghere <jonas at devlieghere.com>
  Date:   2020-01-24 (Fri, 24 Jan 2020)

  Changed paths:
    M lldb/tools/debugserver/source/DNBArch.h
    M lldb/tools/debugserver/source/MacOSX/MachThread.cpp
    M lldb/tools/debugserver/source/MacOSX/MachThread.h
    M lldb/tools/debugserver/source/MacOSX/MachThreadList.cpp
    M lldb/tools/debugserver/source/MacOSX/MachThreadList.h

  Log Message:
  -----------
  [lldb/debugserver] Unify the breakpoint/watchpoint interface (NFCI)

Unify the interface for enabling and disabling breakpoints with their
watchpoint counterpart. This allows both to go through
DoHardwareBreakpointAction.

Differential revision: https://reviews.llvm.org/D72981


  Commit: 96f3ea0d21b48ca088355db10d4d1a2e9bc9f884
      https://github.com/llvm/llvm-project/commit/96f3ea0d21b48ca088355db10d4d1a2e9bc9f884
  Author: Jonas Devlieghere <jonas at devlieghere.com>
  Date:   2020-01-24 (Fri, 24 Jan 2020)

  Changed paths:
    M lldb/packages/Python/lldbsuite/test/functionalities/breakpoint/hardware_breakpoints/hardware_breakpoint_on_multiple_threads/TestHWBreakMultiThread.py
    M lldb/tools/debugserver/source/MacOSX/arm/DNBArchImpl.cpp
    M lldb/tools/debugserver/source/MacOSX/arm/DNBArchImpl.h
    M lldb/tools/debugserver/source/MacOSX/i386/DNBArchImplI386.cpp
    M lldb/tools/debugserver/source/MacOSX/i386/DNBArchImplI386.h
    M lldb/tools/debugserver/source/MacOSX/x86_64/DNBArchImplX86_64.cpp
    M lldb/tools/debugserver/source/MacOSX/x86_64/DNBArchImplX86_64.h
    M lldb/tools/debugserver/source/RNBRemote.cpp

  Log Message:
  -----------
  [lldb/debugserver] Implement hardware breakpoints for x86_64 and i386

This implements hardware breakpoints for x86_64 and i386 in debugserver.
It's based on Pedro's patch sent to lldb-commits [1] although most of it
is the same as the existing hardware watchpoint implementation.

[1] http://lists.llvm.org/pipermail/lldb-commits/Week-of-Mon-20200113/060327.html

Differential revision: https://reviews.llvm.org/D72985


Compare: https://github.com/llvm/llvm-project/compare/e1440f594c14...96f3ea0d21b4