[all-commits] [llvm/llvm-project] 77cedb: [lldb] Fix nondeterminism in TestCppBitfields

[Pavel Labath via All-commits]

  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: 77cedb0cdb8623ff9eb22dbf3b9302ee4d9f8a20
      https://github.com/llvm/llvm-project/commit/77cedb0cdb8623ff9eb22dbf3b9302ee4d9f8a20
  Author: Pavel Labath <pavel at labath.sk>
  Date:   2020-01-24 (Fri, 24 Jan 2020)

  Changed paths:
    M lldb/packages/Python/lldbsuite/test/lang/cpp/bitfields/TestCppBitfields.py
    M lldb/packages/Python/lldbsuite/test/lang/cpp/bitfields/main.cpp

  Log Message:
  -----------
  [lldb] Fix nondeterminism in TestCppBitfields

The test was printing a char[3] variable without a terminating nul. The
memory after that variable (an unnamed bitfield) was not initialized. If
the memory happened to be nonzero, the summary provider for the variable
would run off into the next field.

This is probably not the right behavior (it should stop at the end of
the array), but this is not the purpose of this test. I have filed
pr44649 for this bug, and fixed the test to not depend on this behavior.


  Commit: d4b092b34125d6c571d43a185a1c774244b76957
      https://github.com/llvm/llvm-project/commit/d4b092b34125d6c571d43a185a1c774244b76957
  Author: Pavel Labath <pavel at labath.sk>
  Date:   2020-01-24 (Fri, 24 Jan 2020)

  Changed paths:
    M lldb/source/Plugins/SymbolFile/DWARF/DebugNamesDWARFIndex.cpp

  Log Message:
  -----------
  [lldb/DWARF] Remove a workaround from DebugNamesDWARFIndex

This was needed when asking a compile unit for its dwo component
triggered a infinite recursion if the dwo unit has not been already
parsed.

This has since been fixed.


Compare: https://github.com/llvm/llvm-project/compare/0ae13766ffd8...d4b092b34125