[all-commits] [llvm/llvm-project] fcaf5f: [LLDB] Fix the handling of unnamed bit-fields when...

[Shafik Yaghmour via All-commits]

  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: fcaf5f6c01a09f23b948afb8c91c4dd951d4525e
      https://github.com/llvm/llvm-project/commit/fcaf5f6c01a09f23b948afb8c91c4dd951d4525e
  Author: shafik <syaghmour at apple.com>
  Date:   2020-01-23 (Thu, 23 Jan 2020)

  Changed paths:
    A lldb/packages/Python/lldbsuite/test/lang/cpp/bitfields/Makefile
    A lldb/packages/Python/lldbsuite/test/lang/cpp/bitfields/TestCppBitfields.py
    A lldb/packages/Python/lldbsuite/test/lang/cpp/bitfields/main.cpp
    M lldb/source/Plugins/SymbolFile/DWARF/DWARFASTParserClang.cpp
    M lldb/source/Plugins/SymbolFile/DWARF/DWARFASTParserClang.h

  Log Message:
  -----------
  [LLDB] Fix the handling of unnamed bit-fields when parsing DWARF

We ran into an assert when debugging clang and performing an expression on a class derived from DeclContext. The assert was indicating we were getting the offsets wrong for RecordDeclBitfields. We were getting both the size and offset of unnamed bit-field members wrong. We could fix this case with a quick change but as I extended the test suite to include more combinations we kept finding more cases that were being handled incorrectly. A fix that handled all the new cases as well as the cases already covered required a refactor of the existing technique.

Differential Revision: https://reviews.llvm.org/D72953