[all-commits] [llvm/llvm-project] c8695b: Revert "[mlir] Add baseAttr to TypedArrayAttrBase."

ftynse via All-commits all-commits at lists.llvm.org
Thu Jan 23 05:49:26 PST 2020


  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: c8695ba9cdebfc25af3312a84d91ae6f0f98487b
      https://github.com/llvm/llvm-project/commit/c8695ba9cdebfc25af3312a84d91ae6f0f98487b
  Author: Alex Zinenko <zinenko at google.com>
  Date:   2020-01-23 (Thu, 23 Jan 2020)

  Changed paths:
    M mlir/include/mlir/IR/OpBase.td

  Log Message:
  -----------
  Revert "[mlir] Add baseAttr to TypedArrayAttrBase."

This reverts commit eec36909c18b8788773abc95d199e6acde6eb42c.

This modeling is incorrect. baseAttr is intended for attribute
decorators that are not backed by C++ attribute classes. It essentially
says DerivedAttr isa BaseAttr, which is wrong for ArrayAttr classes.
If one needs to store the element type, it should be stored as a
separate filed in the tablegen class.




More information about the All-commits mailing list