[all-commits] [llvm/llvm-project] f1ad19: [FileCheck] Strengthen error checks in unit tests

[RoboTux via All-commits]

  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: f1ad192915f64e3eeedfb01aa1073e81bff4e1a1
      https://github.com/llvm/llvm-project/commit/f1ad192915f64e3eeedfb01aa1073e81bff4e1a1
  Author: Thomas Preud'homme <thomasp at graphcore.ai>
  Date:   2020-01-23 (Thu, 23 Jan 2020)

  Changed paths:
    M llvm/unittests/Support/FileCheckTest.cpp

  Log Message:
  -----------
  [FileCheck] Strengthen error checks in unit tests

Summary:
This commit adds error checking beyond UndefVarError and fix a number of
Error/Expected related idioms:
- use (EXPECT|ASSERT)_THAT_(ERROR|EXPECTED) instead of errorToBool or
  boolean operator
- ASSERT when a further check require the check to be successful to give
  a correct result

Reviewers: jhenderson, jdenny, probinson, grimar, arichardson, rnk

Reviewed By: jhenderson

Subscribers: llvm-commits

Tags: #llvm

Differential Revision: https://reviews.llvm.org/D72914