[all-commits] [llvm/llvm-project] c42fe2: [lld/ELF] PR44498: Support input filename in doubl...

[RoboTux via All-commits]

  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: c42fe24754f4a2173d16b799085cec88cad6f24c
      https://github.com/llvm/llvm-project/commit/c42fe24754f4a2173d16b799085cec88cad6f24c
  Author: Thomas Preud'homme <thomasp at graphcore.ai>
  Date:   2020-01-22 (Wed, 22 Jan 2020)

  Changed paths:
    M lld/Common/Strings.cpp
    M lld/ELF/LinkerScript.h
    M lld/ELF/ScriptParser.cpp
    M lld/ELF/SymbolTable.cpp
    M lld/include/lld/Common/Strings.h
    M lld/test/ELF/linkerscript/filename-spec.s

  Log Message:
  -----------
  [lld/ELF] PR44498: Support input filename in double quote

Summary:
Linker scripts allow filenames to be put in double quotes to prevent
characters in filenames that are part of the linker script syntax from
having their special meaning. Case in point the * wildcard character.

Availability of double quoting filenames also allows to fix a failure in
ELF/linkerscript/filename-spec.s when the path contain a @ which the
lexer consider as a special characters and thus break up a filename
containing it. This may happens under Jenkins which createspath such as
pipeline at 2.

To avoid the need for escaping GlobPattern metacharacters in filename
in double quotes, GlobPattern::create is augmented with a new parameter
to request literal matching instead of relying on the presence of a
wildcard character in the pattern.

Reviewers: jhenderson, MaskRay, evgeny777, espindola, alexshap

Reviewed By: MaskRay

Subscribers: peter.smith, grimar, ruiu, emaste, arichardson, hiraditya, llvm-commits

Tags: #llvm

Differential Revision: https://reviews.llvm.org/D72517