[all-commits] [llvm/llvm-project] 935729: Change the googlemock link

[Pavel Labath via All-commits]

  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: 935729e4c63a07570f16f5d6112903f349365775
      https://github.com/llvm/llvm-project/commit/935729e4c63a07570f16f5d6112903f349365775
  Author: Sunil Singh <sunilp896 at gmail.com>
  Date:   2020-01-22 (Wed, 22 Jan 2020)

  Changed paths:
    M llvm/docs/TestingGuide.rst

  Log Message:
  -----------
  Change the googlemock link

Summary:
This commit changes the googlemock link in the Testing Guide doc as googlemock is absorbed into the GoogleTest project

Reviewers: shafik, labath, JDevlieghere, mib

Reviewed By: labath

Subscribers: llvm-commits

Tags: #llvm

Differential Revision: https://reviews.llvm.org/D73082


  Commit: 0157a74bec3d2ef1fac5b874327b97d2ae8e95c8
      https://github.com/llvm/llvm-project/commit/0157a74bec3d2ef1fac5b874327b97d2ae8e95c8
  Author: Pavel Labath <pavel at labath.sk>
  Date:   2020-01-22 (Wed, 22 Jan 2020)

  Changed paths:
    M lldb/packages/Python/lldbsuite/test/functionalities/breakpoint/comp_dir_symlink/TestCompDirSymLink.py
    M lldb/source/Host/posix/FileSystemPosix.cpp

  Log Message:
  -----------
  [lldb] Fix an asan error from 27df2d9f556c

This error is caused by a combination of a couple of factors:
- the test accidentally creating a list with a single (empty) FileSpec
  instead of an empty list
- lldb overzeleously converting empty strings into nullptrs
- asan overzeleously validating symlink(2) arguments (the real symlink
  call would just fail with EFAULT)

I fix this by using FileSpec::GetPath instead of GetCString. This avoids
the nullptr and also avoids inserting the path into the global string
pool.

I also enhance the test case to test both empty paths and empty lists.


Compare: https://github.com/llvm/llvm-project/compare/5d4e89975714...0157a74bec3d