[all-commits] [llvm/llvm-project] 6e73fe: List implicit operator== after implicit destructor...

Richard Smith via All-commits all-commits at lists.llvm.org
Tue Jan 21 15:55:01 PST 2020


  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: 6e73fee780839bfa95aff492864e93e79910380b
      https://github.com/llvm/llvm-project/commit/6e73fee780839bfa95aff492864e93e79910380b
  Author: Richard Smith <richard at metafoo.co.uk>
  Date:   2020-01-21 (Tue, 21 Jan 2020)

  Changed paths:
    M clang/lib/AST/VTableBuilder.cpp
    A clang/test/CodeGenCXX/virtual-compare.cpp

  Log Message:
  -----------
  List implicit operator== after implicit destructors in a vtable.

Summary:
We previously listed first declared members, then implicit operator=,
then implicit operator==, then implicit destructors. Per discussion on
https://github.com/itanium-cxx-abi/cxx-abi/issues/88, put the implicit
equality comparison operators at the very end, after all special member
functions.

This reinstates add2b7e44ada46f30715b5c48823a9e9e317e0c3, reverted in
commit 89e43f04ba87a0da6e94863db149669c7536486b, with a fix for 32-bit
targets.

Reviewers: rjmccall

Subscribers: cfe-commits

Tags: #clang

Differential Revision: https://reviews.llvm.org/D72897




More information about the All-commits mailing list