[all-commits] [llvm/llvm-project] b70e4e: [mlir] Generalize broadcastable trait operands

Jacques Pienaar via All-commits all-commits at lists.llvm.org
Mon Jan 20 13:02:33 PST 2020


  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: b70e4efb75bf1670fa335f3211c05b26b060ffde
      https://github.com/llvm/llvm-project/commit/b70e4efb75bf1670fa335f3211c05b26b060ffde
  Author: Jacques Pienaar <jpienaar at google.com>
  Date:   2020-01-20 (Mon, 20 Jan 2020)

  Changed paths:
    M mlir/docs/Traits.md
    M mlir/include/mlir/Dialect/Traits.h
    M mlir/include/mlir/IR/OpBase.td
    M mlir/lib/Dialect/Traits.cpp
    M mlir/test/Dialect/traits.mlir
    M mlir/test/lib/TestDialect/TestOps.td
    M mlir/tools/mlir-tblgen/RewriterGen.cpp

  Log Message:
  -----------
  [mlir] Generalize broadcastable trait operands

Summary:
Generalize broadcastable trait to variadic operands. Update the
documentation that still talked about element type as part of
broadcastable trait (that bug was already fixed). Also rename
Broadcastable to ResultBroadcastableShape to be more explicit that the
trait affects the result shape (it is possible for op to allow
broadcastable operands but not have result shape that is broadcast
compatible with operands).

Doing some intermediate work to have getBroadcastedType take an optional
elementType as input and use that if specified, instead of the common
element type of type1 and type2 in this function.

Differential Revision: https://reviews.llvm.org/D72559




More information about the All-commits mailing list