[all-commits] [llvm/llvm-project] 24b7b9: [llvm-exegesis][NFC] Disassociate snippet generato...

Miloš Stojanović via All-commits all-commits at lists.llvm.org
Mon Jan 20 07:32:26 PST 2020


  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: 24b7b99b7d68e1a234078eff639ccfbb7661eee5
      https://github.com/llvm/llvm-project/commit/24b7b99b7d68e1a234078eff639ccfbb7661eee5
  Author: Miloš Stojanović <Milos.Stojanovic at rt-rk.com>
  Date:   2020-01-20 (Mon, 20 Jan 2020)

  Changed paths:
    M llvm/tools/llvm-exegesis/lib/AArch64/Target.cpp
    M llvm/tools/llvm-exegesis/lib/Analysis.cpp
    M llvm/tools/llvm-exegesis/lib/CMakeLists.txt
    R llvm/tools/llvm-exegesis/lib/Latency.cpp
    R llvm/tools/llvm-exegesis/lib/Latency.h
    A llvm/tools/llvm-exegesis/lib/LatencyBenchmarkRunner.cpp
    A llvm/tools/llvm-exegesis/lib/LatencyBenchmarkRunner.h
    M llvm/tools/llvm-exegesis/lib/Mips/Target.cpp
    A llvm/tools/llvm-exegesis/lib/ParallelSnippetGenerator.cpp
    A llvm/tools/llvm-exegesis/lib/ParallelSnippetGenerator.h
    M llvm/tools/llvm-exegesis/lib/PowerPC/Target.cpp
    A llvm/tools/llvm-exegesis/lib/SerialSnippetGenerator.cpp
    A llvm/tools/llvm-exegesis/lib/SerialSnippetGenerator.h
    M llvm/tools/llvm-exegesis/lib/Target.cpp
    M llvm/tools/llvm-exegesis/lib/Target.h
    R llvm/tools/llvm-exegesis/lib/Uops.cpp
    R llvm/tools/llvm-exegesis/lib/Uops.h
    A llvm/tools/llvm-exegesis/lib/UopsBenchmarkRunner.cpp
    A llvm/tools/llvm-exegesis/lib/UopsBenchmarkRunner.h
    M llvm/tools/llvm-exegesis/lib/X86/Target.cpp
    M llvm/unittests/tools/llvm-exegesis/Mips/SnippetGeneratorTest.cpp
    M llvm/unittests/tools/llvm-exegesis/X86/SnippetGeneratorTest.cpp
    M llvm/unittests/tools/llvm-exegesis/X86/SnippetRepetitorTest.cpp
    M llvm/unittests/tools/llvm-exegesis/X86/TestBase.h

  Log Message:
  -----------
  [llvm-exegesis][NFC] Disassociate snippet generators from benchmark runners

The addition of `inverse_throughput` mode highlighted the disjointedness
of snippet generators and benchmark runners because it used the
`UopsSnippetGenerator` with the  `LatencyBenchmarkRunner`.
To keep the code consistent tie the snippet generators to
parallelization/serialization rather than their benchmark runners.

Renaming `LatencySnippetGenerator` -> `SerialSnippetGenerator`.
Renaming `UopsSnippetGenerator` -> `ParallelSnippetGenerator`.

Differential Revision: https://reviews.llvm.org/D72928




More information about the All-commits mailing list