[all-commits] [llvm/llvm-project] 39f133: Make SymbolFileDWARF::ParseLineTable use std::sort...

Pavel Labath via All-commits all-commits at lists.llvm.org
Mon Jan 20 03:54:07 PST 2020


  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: 39f1335486eae355b2259d59549382e5cee9e38f
      https://github.com/llvm/llvm-project/commit/39f1335486eae355b2259d59549382e5cee9e38f
  Author: Unnar Freyr Erlendsson <unnar at google.com>
  Date:   2020-01-20 (Mon, 20 Jan 2020)

  Changed paths:
    M lldb/include/lldb/Symbol/LineTable.h
    M lldb/source/Plugins/SymbolFile/DWARF/SymbolFileDWARF.cpp
    M lldb/source/Symbol/LineTable.cpp

  Log Message:
  -----------
  Make SymbolFileDWARF::ParseLineTable use std::sort instead of insertion sort

Summary:
Motivation: When setting breakpoints in certain projects line sequences are frequently being inserted out of order.

Rather than inserting sequences one at a time into a sorted line table, store all the line sequences as we're building them up and sort and flatten afterwards.

Reviewers: jdoerfert, labath

Reviewed By: labath

Subscribers: teemperor, labath, mgrang, JDevlieghere, lldb-commits

Tags: #lldb

Differential Revision: https://reviews.llvm.org/D72909




More information about the All-commits mailing list