[all-commits] [llvm/llvm-project] 5fa202: [X86] Remove X86ISD::FILD_FLAG and stop gluing nod...

topperc via All-commits all-commits at lists.llvm.org
Sat Jan 18 21:44:28 PST 2020


  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: 5fa2022ec0051bad4f37025233d6e888808a219c
      https://github.com/llvm/llvm-project/commit/5fa2022ec0051bad4f37025233d6e888808a219c
  Author: Craig Topper <craig.topper at gmail.com>
  Date:   2020-01-18 (Sat, 18 Jan 2020)

  Changed paths:
    M llvm/lib/Target/X86/X86ISelLowering.cpp
    M llvm/lib/Target/X86/X86ISelLowering.h
    M llvm/lib/Target/X86/X86InstrFPStack.td
    M llvm/test/CodeGen/X86/vec-strict-inttofp-256.ll
    M llvm/test/CodeGen/X86/vec-strict-inttofp-512.ll

  Log Message:
  -----------
  [X86] Remove X86ISD::FILD_FLAG and stop gluing nodes together.

Summary:
I think whatever problem the gluing was fixing has long since been fixed. We don't have any of the restrictions on FP stack stuff that existed back when this was first added.

I had to change which type we use for FILD in BuildFILD when X86 was enabled because most of the isel patterns block f32/f64 instructions when SSE1/SSE2 are enabled. So I needed to use the f80 pattern, but this shouldn't have an effect the generated code since there is only one FILD instruction anyway. We already use f80 explicitly in other other places.

Reviewers: RKSimon, spatel

Reviewed By: RKSimon

Subscribers: andrew.w.kaylor, scanon, hiraditya, llvm-commits

Tags: #llvm

Differential Revision: https://reviews.llvm.org/D72805




More information about the All-commits mailing list