[all-commits] [llvm/llvm-project] 002ec7: [mlir] NFC: Rename index_t to index_type

[rorth via All-commits]

  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: 002ec79f979b9da9dedafe7ea036e00c90a9fbb7
      https://github.com/llvm/llvm-project/commit/002ec79f979b9da9dedafe7ea036e00c90a9fbb7
  Author: Rainer Orth <ro at CeBiTec.Uni-Bielefeld.DE>
  Date:   2020-01-18 (Sat, 18 Jan 2020)

  Changed paths:
    M mlir/docs/EDSC.md
    M mlir/include/mlir/EDSC/Builders.h
    M mlir/include/mlir/EDSC/Intrinsics.h
    M mlir/lib/Conversion/VectorToLoops/ConvertVectorToLoops.cpp
    M mlir/lib/EDSC/Builders.cpp
    M mlir/lib/EDSC/Helpers.cpp
    M mlir/test/EDSC/builder-api-test.cpp

  Log Message:
  -----------
  [mlir] NFC: Rename index_t to index_type

mlir currently fails to build on Solaris:

  /vol/llvm/src/llvm-project/dist/mlir/lib/Conversion/VectorToLoops/ConvertVectorToLoops.cpp:78:20: error: reference to 'index_t' is ambiguous
    IndexHandle zero(index_t(0)), one(index_t(1));
                     ^
  /usr/include/sys/types.h:103:16: note: candidate found by name lookup is 'index_t'
  typedef short           index_t;
                          ^
  /vol/llvm/src/llvm-project/dist/mlir/include/mlir/EDSC/Builders.h:27:8: note: candidate found by name lookup is 'mlir::edsc::index_t'
  struct index_t {
         ^

and many more.

Given that POSIX reserves all identifiers ending in `_t` 2.2.2 The Name Space <https://pubs.opengroup.org/onlinepubs/9699919799/functions/V2_chap02.html>, it seems
quite unwise to use such identifiers in user code, even more so without a distinguished
prefix.

The following patch fixes this by renaming `index_t` to `index_type`.
cases.

Tested on `amd64-pc-solaris2.11` and `sparcv9-sun-solaris2.11`.

Differential Revision: https://reviews.llvm.org/D72619