[all-commits] [llvm/llvm-project] 33463c: clang-format: fix spacing in `operator const char*()`
Krasimir Georgiev via All-commits
all-commits at lists.llvm.org
Fri Jan 17 04:34:29 PST 2020
Branch: refs/heads/master
Home: https://github.com/llvm/llvm-project
Commit: 33463cfba2be7c8d6c08e666123cc34f114a1f3e
https://github.com/llvm/llvm-project/commit/33463cfba2be7c8d6c08e666123cc34f114a1f3e
Author: Krasimir Georgiev <krasimir at google.com>
Date: 2020-01-17 (Fri, 17 Jan 2020)
Changed paths:
M clang/lib/Format/TokenAnnotator.cpp
M clang/unittests/Format/FormatTest.cpp
Log Message:
-----------
clang-format: fix spacing in `operator const char*()`
Summary:
Revision a75f8d98d7ac9e557b238a229a9a2647c71feed1 fixed spacing for operators,
but caused the const and non-const versions to diverge:
```
// With Style.PointerAlignment = FormatStyle::PAS_Left:
struct A {
operator char*() { return ""; }
operator const char *() const { return ""; }
};
```
The code was checking if the type specifier was directly preceded by `operator`.
However there could be comments and `const/volatile` in between.
Reviewers: mprobst
Reviewed By: mprobst
Subscribers: cfe-commits
Tags: #clang
Differential Revision: https://reviews.llvm.org/D72911
More information about the All-commits
mailing list